Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepsomatic module scaffolding #6622

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vaxyzek
Copy link

@vaxyzek vaxyzek commented Sep 10, 2024

This is a first version of PR to add deepsomatic capabilities into nf-core/modules. Currently this PR contains code changes only (without tests and most of metadata) and created to gather the initial feedback.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@vaxyzek vaxyzek requested a review from a team as a code owner September 10, 2024 17:04
@vaxyzek vaxyzek requested review from mashehu and removed request for a team September 10, 2024 17:04
@vaxyzek vaxyzek marked this pull request as draft September 10, 2024 17:05
@maxulysse maxulysse mentioned this pull request Sep 12, 2024
11 tasks
@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

Copy link

Nothing for me to do here! 🤷
This is probably because the linting errors come from nf-core lint and have to be fixed manually (or with nf-core lint --fix).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted since there is no bioconda recipe for this yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping we should be able to use the same data that is used on the mutect2 tests:
https://github.com/nf-core/modules/blob/master/modules/nf-core/gatk4/mutect2/tests/main.nf.test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants