Be consistent in GHA names, only use Setup, remove Set up or Install #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
requested changes
Oct 11, 2024
| uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4 | ||
| with: | ||
| node-version: "20" | ||
|
|
||
| - name: Install Prettier | ||
| - name: Set up Prettier |
There was a problem hiding this comment.
this is a install step
Suggested change
| - name: Set up Prettier | |
| - name: Install Prettier |
| @@ -64,7 +64,7 @@ jobs: | |||
| with: | |||
| node-version: "20" | |||
|
|
|||
| - name: Install editorconfig-checker | |||
| - name: Set up editorconfig-checker | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up editorconfig-checker | |
| - name: Install editorconfig-checker |
| @@ -163,18 +163,18 @@ jobs: | |||
| restore-keys: | | |||
| ${{ runner.os }}-pip | |||
|
|
|||
| - name: Install pip | |||
| - name: Set up pip | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up pip | |
| - name: Update pip |
There was a problem hiding this comment.
not sure if we actually need this step anymore
| uses: nf-core/setup-nextflow@v2 | ||
|
|
||
| - name: Install nf-core tools development version | ||
| - name: Set up nf-core tools development version |
There was a problem hiding this comment.
Suggested change
| - name: Set up nf-core tools development version | |
| - name: Install nf-core tools development version |
| @@ -201,18 +201,18 @@ jobs: | |||
| with: | |||
| python-version: "3.11" | |||
|
|
|||
| - name: Install pip | |||
| - name: Set up pip | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up pip | |
| - name: Update pip |
| uses: nf-core/setup-nextflow@561fcfc7146dcb12e3871909b635ab092a781f34 # v2 | ||
|
|
||
| - name: Install nf-core tools development version | ||
| - name: Set up nf-core tools development version |
There was a problem hiding this comment.
Suggested change
| - name: Set up nf-core tools development version | |
| - name: Install nf-core tools development version |
| @@ -413,19 +413,19 @@ jobs: | |||
| restore-keys: | | |||
| ${{ runner.os }}-pip-pytest | |||
|
|
|||
| - name: Install Python dependencies | |||
| - name: Set up Python dependencies | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up Python dependencies | |
| - name: Install Python dependencies |
Comment on lines
444
to
448
|
|
||
| - name: Conda setup | ||
| - name: Set up Conda | ||
| run: | | ||
| conda clean -a | ||
| conda install -n base conda-libmamba-solver |
There was a problem hiding this comment.
this setup step can be removed if we add the conda-solver: to the setup-minoconda step
| @@ -690,7 +690,7 @@ jobs: | |||
| restore-keys: | | |||
| ${{ runner.os }}-pip-pdiff | |||
|
|
|||
| - name: Install Python dependencies | |||
| - name: Set up Python dependencies | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up Python dependencies | |
| - name: Install Python dependencies |
| @@ -701,7 +701,7 @@ jobs: | |||
| auto-update-conda: true | |||
| channels: conda-forge,bioconda | |||
|
|
|||
| - name: Conda setup | |||
| - name: Set up Conda | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda