Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tar to always follow symlinks due to nxf staging in work dirs #6778

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix tar to always follow symlinks due to nxf staging in work dirs #6778

merged 1 commit into from
Oct 14, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 14, 2024

Forget this bit 😅

@jfy133 jfy133 marked this pull request as ready for review October 14, 2024 09:56
mahesh-panchal
mahesh-panchal approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Does that mean all files are in the archive resolve to their full files when decompressed?

@jfy133
Copy link
Member Author

jfy133 commented Oct 14, 2024

Now yes!

@jfy133 jfy133 added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@jfy133 jfy133 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit a4835a6 Oct 14, 2024
12 checks passed
@jfy133 jfy133 deleted the fix-tar branch October 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @mahesh-panchal