Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeepVariant #7171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented Dec 6, 2024

Fixing the conda recipe seems to have become even harder after 1.6.1: bioconda/bioconda-recipes#45214 (comment).

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@fellen31 fellen31 requested a review from edmundmiller December 6, 2024 11:21
@fellen31
Copy link
Contributor Author

fellen31 commented Dec 6, 2024

Could someone with access please create nf-core/deepvariant:1.8.0?

@edmundmiller
Copy link
Contributor

I'll upload it @fellen31!

Choosing to do this so they get automatically bumped by renovate in the future.
@edmundmiller
Copy link
Contributor

Hey @fellen31

I decided to go with the Google image itself, choosing to do this so they get automatically bumped by #4211 in the future whenever a new image get's tagged by the google team so there's less lag and hopefully no human standing in the way of a version bump.

@edmundmiller edmundmiller marked this pull request as ready for review December 11, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants