Update subworkflow for deepvariant to version 1.8.0 #7473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the deepvariant variant calling subworkflow (nf-core/deepvariant) to version 1.8.0.
Other module subcommands were updated in #7301.
This work is based on @fellen31's original pull request to update the subworkflow, and adds some handling of the "small model". Summary of changes:
The future of the subworkflow in nf-core is a bit uncertain. Recent updates of DeepVariant have required an excessive amount of changes to be made in the subworkflow. Due to the argument handling with
ext.args
, they would also require many changes by the pipelines using the subworkflow, to keep up with the default arguments used by therun_deepvariant
script.The purpose of this subworkflow is to optimize compute resource usage, allocating GPUs only when needed. With version 1.8.0, Google released a new "fast pipeline" (https://github.com/google/deepvariant/blob/r1.8/docs/deepvariant-fast-pipeline-case-study.md) that could solve the same problem in a different way. At the moment, the fast pipeline is about as complex as the subworkflow approach, so I'm suggesting we keep the subworkflow for now.
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda