Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatk4/markduplicates - pipe uncompressed output to speed up CRAM writing #7497

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pontushojer
Copy link

WIP! This is my first PR to nf-core/modules. I have not gotten this to work locally yet but figured I would share anyway.

I was running nf-core/sarek which uses this module for duplicate marking. When using CRAM output this module currently writes a BAM and then converts it to CRAM. This is quite wasteful, on one of my samples the MarkDuplicates finished after 153 minutes while the module duration was 224 minutes, that's an additional 71 minutes for CRAM output.

In this PR the output is instead piped as uncompressed BAM to �samtools which writes output to the desired format. I have not done any benchmarks yet but judging from this article it should be comparable to just running MarkDuplicates.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant