gatk4/markduplicates - pipe uncompressed output to speed up CRAM writing #7497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP! This is my first PR to nf-core/modules. I have not gotten this to work locally yet but figured I would share anyway.
I was running nf-core/sarek which uses this module for duplicate marking. When using CRAM output this module currently writes a BAM and then converts it to CRAM. This is quite wasteful, on one of my samples the MarkDuplicates finished after 153 minutes while the module duration was 224 minutes, that's an additional 71 minutes for CRAM output.
In this PR the output is instead piped as uncompressed BAM to
�samtools
which writes output to the desired format. I have not done any benchmarks yet but judging from this article it should be comparable to just runningMarkDuplicates
.PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda