-
Notifications
You must be signed in to change notification settings - Fork 872
New module: mobster #8647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New module: mobster #8647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution. The module is already quite solid. I've left a few technical comments for your consideration.
label "process_high" | ||
|
||
conda "${moduleDir}/environment.yml" | ||
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a Seqera container with the tools? They are more reliable than Biocontainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! thank your for your comment. My lab and I are developing an nf-core pipeline (https://nf-co.re/tumourevo/dev/) and after the first release comments, some of your collegues suggested to use biocontainers for our modules, that's why we proceeded with those. Is it ok or should I update the containers to sequera ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a single module, biocontainers should be fine (although I recall some issues with Singularity). However, with multiple, it is much more reliable and convenient to use Seqera Containers instead of mulled biocontainers.
Hi @itrujnara! thank you for your comments, I should've addressed all of them (I've left a comment for the Docker/Singularity containers). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can consider switching to Seqera Containers for convenience. Otherwise, the module looks fine now.
PR checklist
Closes #8689
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda