Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2283_Cell_types_with_missing_definition #2289

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

AvolaAmg
Copy link
Collaborator

2283_Cell_types_with_missing_definition

2283_Cell_types_with_missing_definition
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these definitions. Most of the definitions are good, see inline comments. I have suggested to change some references that might be more specific for the term.
For one of the terms, the dbxrefs are in the wrong annotation property and have to be changed.
The logical definition of kidney blood vessel cell is too narrow. Would you like to create a new ticket to address it?

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@AvolaAmg
Copy link
Collaborator Author

Thank you for your review and help. I will implement based on your comment and rise a new ticket for the logical definition of the blood vessel.

@AvolaAmg
Copy link
Collaborator Author

[Logical def] Kidney blood vessel cell revise logical definition #2290

Deleted reference in Kidney outer medulla interstitial cell
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@aleixpuigb aleixpuigb merged commit 477adbf into master Feb 23, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the 2283_Cell_types_with_missing_definition branch February 23, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Text def] Cell types with missing definition
2 participants