-
Notifications
You must be signed in to change notification settings - Fork 99
dev meeting 20201105
Present at the meeting:
- Jérémie Dimino (@jeremiedimino)
- Carl Eastlund (@ceastlund)
- Sonja Heinze (@pitag-ha)
- Carl keeps on updating the Jane Street PPX's to OMP2 and porting ppx_import to ppxlib
- Nathan adds the required features for bucklescript compat of the as_ppx driver
- Sonja finishes the bisect_ppx port and for that adds a
context
argument to theregister
callbacks
Sonja is still working on Aslib. We've discussed the central types of the Location
module. She will make them abstract and for that drop the type equivalences of the types in Ast_x
with the correspondent types from the compiler, where x
is the compiler version used. That will cause having to convert to the compiler types at some places. We'll get away with Obj.magic
for now, but we'll need a story for this in the long term. The Location.error
type depends on the compiler version. She'll make it abstract in a separate module whose implementation takes the different versions into account. That part of the API will diverge from the compiler-libs API, but we don't need to take compiler-libs as a model for Astlib, and in fact shouldn’t. To format Astlib, it would be useful to use Ocamlformat in ppxlib, at least on the files not using cinaps
. For that, Nathan will check if we can use the ocaml-ci
for ppxlib.
The bisect_ppx port still depends on having access to Location.input_name
- Sonja will work on that next week by adding a context
argument to the register
callbacks - and the buckle script support Nathan is working on.
Carl started updating the Jane Street PPX's to OMP2. It's almost done. It will eventually need bisect_ppx relying on OMP2/ppxlib as well. That's not blocking for the Jane Street CI, but other people might use it. He's also working on porting ppx_import to ppxlib. One test is broken; it needs to be ported from ppx_deriving to ppxlib.
For the immediate future, we will prioritise the various small features on ppxlib over Astlib that come up porting other projects to ppxlib. We'll try to wrap them up before winter.