dev meeting 20201126

Present at the meeting:

• Jérémie Dimino (@jeremiedimino)
• Sonja Heinze (@pitag-ha)

Current plan

• Sonja writes a test for adding a context argument to the register callbacks
• Sonja rewrites the run_as_ppx_rewriter implementation
• Sonja adds a feature to preserve the AST version if wanted.

Meeting notes

Sonja has added an expansion context argument to the register callbacks in a Version 2 of the register functions. She's tested the result by using it in bisect_ppx. To test it internally, the ppx_expect test workflow used for other ppxlib features is not a good option, since that uses map_structure as an entry point and therefore yields _none_ as input name. She will make a cram test or similar for it. Furthermore, the current implementation of the run_as_ppx_rewriter entry point forces her to internally access the input name via compiler-libs instead of inferring it. Since run_as_ppx_rewriter uses Ast_mapper and therefore needs to get rewritten anyways for Astlib, she'll rewrite it now. She will also add a new driver feature to preserve the AST version if wanted. That's needed to support bucklescript and therefore to finish porting bisect_ppx.