Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hammer humble/update kc #979

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Hammer humble/update kc #979

merged 7 commits into from
Jul 31, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Jul 29, 2024 •
edited
Loading

What's new

Updating keycloak-js due to the extremely outdated version we are still using, and that it doesn't work with keycloak version 17 and above due to https://www.keycloak.org/migration/migrating-to-quarkus

Update to

  • node 18
  • pnpm to 9
  • keycloak-js to 22.0.5
  • canvas to 2.11.2

requires environment variable NODE_OPTIONS=--openssl-legacy-provider

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth aaronchongth marked this pull request as draft July 30, 2024 03:04
@aaronchongth aaronchongth marked this pull request as ready for review July 30, 2024 10:14
@aaronchongth aaronchongth merged commit 690a163 into deploy/hammer-humble Jul 31, 2024
3 checks passed
@aaronchongth aaronchongth deleted the hammer-humble/update-kc branch July 31, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @koonpeng