Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for rmf_site_format without the bevy feature #159

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Aug 11, 2023

Bug fix

Fixed bug

Fixes #158

Fix applied

Fix compilation without the bevy feature for rmf_site_format, as well as add workflows for all supported platforms to make sure the issue doesn't reappear.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
@luca-della-vedova luca-della-vedova changed the title WIP: Fix compilation for rmf_site_format Fix compilation for rmf_site_format without the bevy feature Aug 11, 2023
@luca-della-vedova luca-della-vedova marked this pull request as ready for review August 11, 2023 07:09
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a CI step that tests a minimal feature build of rmf_site_format so hopefully we catch these errors in the CI from now on.

@mxgrey mxgrey merged commit a9a64b8 into main Aug 25, 2023
5 checks passed
@mxgrey mxgrey deleted the fix/rmf_site_format_compilation branch August 25, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to resolve: use of undeclared crate or module bevy with colcon build
2 participants