Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build with colcon-cargo #160

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Support build with colcon-cargo #160

merged 4 commits into from
Aug 28, 2023

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Aug 11, 2023 •
edited
Loading

Yadunund and others added 3 commits August 11, 2023 12:32
@mxgrey mxgrey marked this pull request as ready for review August 25, 2023 05:46
mxgrey
mxgrey approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go ahead and merge these even if the upstream requirements aren't met. The files don't have any negative impact in the meantime.

@Yadunund
Copy link
Member Author

Could you use admin powers to merge this in? 😅

@mxgrey mxgrey merged commit c86da63 into main Aug 28, 2023
5 checks passed
@mxgrey mxgrey deleted the yadu/ament_cargo branch August 28, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yadunund @mxgrey