Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded tx_id from Stake / Unstake Ack packets #80

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

maurolacy
Copy link
Collaborator

These are harmless. Just for clarity.

@maurolacy maurolacy requested a review from ethanfrey June 28, 2023 07:49
Copy link
Collaborator

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added at your request for clarity, but happy to remove them

@maurolacy maurolacy mentioned this pull request Jun 28, 2023
@maurolacy
Copy link
Collaborator Author

Looks good. I added at your request for clarity, but happy to remove them

Yeah, I thought at the moment these were needed; but they are not / redundant.

@maurolacy maurolacy merged commit df58e1a into main Jun 28, 2023
2 checks passed
@maurolacy maurolacy deleted the remove-tx-id branch November 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants