Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1333] Fix sign-in and confirm sign-in UI and UX #601

Merged
merged 17 commits into from
Feb 14, 2024

Conversation

marcobottaro
Copy link
Collaborator

@marcobottaro marcobottaro commented Feb 5, 2024

Fix sign-in and confirm sign-in UI and UX.
This PR is the first result of the division of the previous PR #486

List of Changes

It changes the UX of the sign-in page and the corresponding confirmation page according to Figma design

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Layout (take a look at the label of password's field:
image

Error management:
image

Confirmation page:
image

Confirmation page error:
image

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 9c659e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1333

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@datalek datalek merged commit c14d7e5 into main Feb 14, 2024
12 checks passed
@datalek datalek deleted the DEV-1333-sign-in-and-confirm-sign-in branch February 14, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants