pcli: add un-advertised support for importing Prax registry data #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a minimal set of changes to allow `pcli` to make use of the Prax registry. In order to not pre-empt more comprehensive planning about how such an integration should work, this PR just changes `pcli` so that if the registry is placed in a `registry.json` file in the `pcli` home directory, it will be imported into the view database on startup.
1 task
hdevalence
commented
Aug 12, 2024
Comment on lines
320
to
+333
| } | ||
| let mut selected_index = 0; | ||
| let mut selected_exponent = 0; | ||
| for (unit_index, unit) in self.inner.units.iter().enumerate() { | ||
| let unit_amount = Amount::from(10u128.pow(unit.exponent as u32)); | ||
| if amount >= unit_amount { | ||
| return Unit { | ||
| unit_index, | ||
| inner: self.inner.clone(), | ||
| }; | ||
| if unit_amount <= amount && unit.exponent >= selected_exponent { | ||
| selected_index = unit_index; | ||
| selected_exponent = unit.exponent; | ||
| } | ||
| } | ||
| self.base_unit() | ||
| return Unit { | ||
| unit_index: selected_index, | ||
| inner: self.inner.clone(), | ||
| }; |
There was a problem hiding this comment.
This bugfix needs a unit test.
It can be triggered by having a Metadata object where the list of units is not sorted. The previous code is incorrect on, for instance, the USDC Metadata currently in the Prax registry. That JSON object could be copied into a unit test, which can create a value like "1.234 USDC", parse it, and check that displaying it round trips (because the correct unit is selected).
|
This doesn't fix problems with argument parsing, a lot of pcli arguments specify denoms and have the string parsing done inside clap, which has to be stateless. Full support will need to change this to take string args and then parse after the app is loaded and the registry can be pulled from the view database. But that can be future work |
aubrika
approved these changes
Aug 12, 2024
conorsch
pushed a commit
that referenced
this pull request
Aug 12, 2024
This makes a minimal set of changes to allow `pcli` to make use of the Prax registry. In order to not pre-empt more comprehensive planning about how such an integration should work, this PR just changes `pcli` so that if the registry is placed in a `registry.json` file in the `pcli` home directory, it will be imported into the view database on startup. (cherry picked from commit 5ed9813)
conorsch
pushed a commit
that referenced
this pull request
Aug 12, 2024
This makes a minimal set of changes to allow `pcli` to make use of the Prax registry. In order to not pre-empt more comprehensive planning about how such an integration should work, this PR just changes `pcli` so that if the registry is placed in a `registry.json` file in the `pcli` home directory, it will be imported into the view database on startup. (cherry picked from commit 5ed9813)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a minimal set of changes to allow
pclito make use of the Prax registry. In order to not pre-empt more comprehensive planning about how such an integration should work, this PR just changespcliso that if the registry is placed in aregistry.jsonfile in thepclihome directory, it will be imported into the view database on startup.If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: