[Bugfix] Workspace walls should get default configurations if customized ones don't exist #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few separate but related changes:
ada_planning_scene
failed to compute workspace walls if robot arm configurations have not been customized. This PR addresses that bug, by havingada_planning_scene
get the default configurations for those that aren't customizing (which aligns with the actual behavior of theada_feeding_action_servers
node.rclpy
bug where spinning crashes when some callbacks are destroyed (#1355, #1206, #1142). This PR creates a very hacky fix, by resuming spinning where it left off.Testing procedure
ada_feeding_action_servers_custom.yaml
file from this PR, but leave everything else unchanged. Re-build your workspace.ros2 launch ada_planning_scene ada_moveit_launch.xml use_rviz:=false sim:=mock
ada_planning_scene
keeps terminating and restarting.ros2 launch ada_planning_scene ada_moveit_launch.xml use_rviz:=false sim:=mock
ada_planning_scene
succesfully populates the workspace walls.Before opening a pull request
python3 -m black .
ada_feeding
directory, run:pylint --recursive=y --rcfile=.pylintrc .
.Before Merging
Squash & Merge