Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade PD client to fix the TSO hang absolutely #51985

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 21, 2024

What problem does this PR solve?

Issue Number: close #51894, close tikv/pd#7849, close #52013.

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #51985 (cc18069) into master (5fd2219) will decrease coverage by 17.7240%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51985         +/-   ##
=================================================
- Coverage   72.3907%   54.6668%   -17.7240%     
=================================================
  Files          1481       1592        +111     
  Lines        365298     610663     +245365     
=================================================
+ Hits         264442     333830      +69388     
- Misses        81271     253625     +172354     
- Partials      19585      23208       +3623     
Flag Coverage Δ
integration 36.6513% <ø> (?)
unit 70.4307% <ø> (-1.8396%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.3985% <ø> (+5.0579%) ⬆️

@zimulala
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 22, 2024
@JmPotato
Copy link
Member Author

/test check-dev2

Copy link

tiprow bot commented Mar 22, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 22, 2024
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 07:45:56.191687147 +0000 UTC m=+1621983.213933536: ☑️ agreed by nolouch.
  • 2024-03-22 07:55:02.803967637 +0000 UTC m=+1622529.826214024: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 3b683d4 into pingcap:master Mar 22, 2024
23 checks passed
@JmPotato JmPotato deleted the fix_tso_hang_must branch March 22, 2024 09:41
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 18, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52710.

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants