-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.2.0dev #8
v0.2.0dev #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM a few minor here-and-there tweaks but most superficial
@@ -0,0 +1,44 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert to YML nhttps://github.com/nf-core/modules/blob/master/.github/ISSUE_TEMPLATE/new_module.yml
|
||
## Required information for the package | ||
|
||
- DOI of publication: https://doi.org/10.1038/s41467-018-07483-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use yml for suggestions, or state that these are exampels to be replaced
labels: "package update" | ||
--- | ||
|
||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yml;ify as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future: #10
Co-authored-by: James A. Fellows Yates <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't feel like I could add much with my review -- it's too far outside of my expertise. But the scripts and templates sure look impressive and what I did understand made sense to me 👍
Added versioning to scripts and helper functions.
Added FastQ file name to initial TSVs to help with PR review.
Closes #7
CHANGELOG:
v0.2.0dev - 25/04/2023
Added
scripts/source_me.sh
: Includes various helper functions for all other scripts.scripts/create_eager_input.sh
: Script to create a preliminary nf-core/eager input TSV from a SSF file.scripts/download_ena_data.py
: Python script to read SSF file, download FastQs from the ENA, and create a file of expected md5sums.scripts/run_download.sh
: Wrapper script to submit the FastQ download job to the local MPI-EVA cluster.scripts/validate_downloaded_data.sh
: Script to validate the downloaded data, and create the intended symlinks for running nf-core/eager.CHANGELOG.md
scripts/run_eager.sh
: Script to run nf-core/eager for all packages that need (re-)running.scripts/submit_as_array.sh
: Helper script for submitting eager jobs as an SGE array on the MPI_EVA cluster.config_profile_description
.Fixed
Dependencies
Deprecated