Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0dev #8

Merged
merged 51 commits into from
May 5, 2023
Merged

v0.2.0dev #8

merged 51 commits into from
May 5, 2023

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Apr 17, 2023

Added versioning to scripts and helper functions.
Added FastQ file name to initial TSVs to help with PR review.

Closes #7

CHANGELOG:

v0.2.0dev - 25/04/2023

Added

  • scripts/source_me.sh: Includes various helper functions for all other scripts.
  • scripts/create_eager_input.sh: Script to create a preliminary nf-core/eager input TSV from a SSF file.
  • scripts/download_ena_data.py: Python script to read SSF file, download FastQs from the ENA, and create a file of expected md5sums.
  • scripts/run_download.sh: Wrapper script to submit the FastQ download job to the local MPI-EVA cluster.
  • scripts/validate_downloaded_data.sh: Script to validate the downloaded data, and create the intended symlinks for running nf-core/eager.
  • Added a Changelog: CHANGELOG.md
  • scripts/run_eager.sh: Script to run nf-core/eager for all packages that need (re-)running.
  • scripts/submit_as_array.sh: Helper script for submitting eager jobs as an SGE array on the MPI_EVA cluster.
  • Github Issue templates
  • Github pull request template
  • @delphis-bot makes the template tsv_patch for a package executable.
  • @delphis-bot now only triggered on new PR comment, not edits.
  • Propagate versions of all config files used in nf-core/eager runs to config_profile_description.

Fixed

Dependencies

Deprecated

@TCLamnidis TCLamnidis changed the title Update v0.2.0dev Apr 25, 2023
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM a few minor here-and-there tweaks but most superficial

@@ -0,0 +1,44 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert to YML nhttps://github.com/nf-core/modules/blob/master/.github/ISSUE_TEMPLATE/new_module.yml

.github/ISSUE_TEMPLATE/request_a_package.md Show resolved Hide resolved

## Required information for the package

- DOI of publication: https://doi.org/10.1038/s41467-018-07483-5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use yml for suggestions, or state that these are exampels to be replaced

labels: "package update"
---

<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml;ify as above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future: #10

.github/ISSUE_TEMPLATE/update_a_package.md Outdated Show resolved Hide resolved
scripts/download_and_localise_package_files.sh Outdated Show resolved Hide resolved
scripts/download_ena_data.py Show resolved Hide resolved
scripts/run_eager.sh Outdated Show resolved Hide resolved
scripts/run_eager.sh Outdated Show resolved Hide resolved
scripts/run_eager.sh Outdated Show resolved Hide resolved
scripts/run_eager.sh Outdated Show resolved Hide resolved
Copy link
Member

@nevrome nevrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't feel like I could add much with my review -- it's too far outside of my expertise. But the scripts and templates sure look impressive and what I did understand made sense to me 👍

.github/ISSUE_TEMPLATE/update_a_package.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
assets/template.config Show resolved Hide resolved
assets/template.config Show resolved Hide resolved
scripts/submit_as_array.sh Show resolved Hide resolved
@TCLamnidis TCLamnidis merged commit 20e6565 into main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the reviewed TSV also include the real name of the FastQ it refers to?
3 participants