feat(fmt): lsp hover #4923
Open
feat(fmt): lsp hover #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4923 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Druue
added a commit
to prisma/language-tools
that referenced
this pull request
Jun 17, 2024
Druue
added a commit
that referenced
this pull request
Jun 17, 2024
Druue
added a commit
that referenced
this pull request
Jun 18, 2024
jkomyno
reviewed
Jun 28, 2024
jkomyno
approved these changes
Jun 28, 2024
Weakky
reviewed
Jul 2, 2024
Weakky
reviewed
Jul 2, 2024
Weakky
reviewed
Jul 2, 2024
Weakky
reviewed
Jul 2, 2024
Druue
commented
Jul 3, 2024
Added ease of use fn to tops: documentation Added Name as model position variant This currently only intentionally triggers over the name of a model and is unimplemented elsewhere. I would ideally leave those as todo to leave it to language-tools in the meantime however language-tools does not currently handle rust panics correctly
…r actually returned as a valid variant, so now it is. Made `iter_tops` on walkers public. Unsure if there's a better way about this; it seemed the most convenient for right now. Added a helper to FieldType to retrieve names. Further clean-up of hover
use topwalker
remove dbg
Show field doc on hover of model and composite field names add conversion methods to enum / composite type scalar fields for composite type field walker general cleanup
hover enum value + doc
Druue
added a commit
to prisma/language-tools
that referenced
this pull request
Jul 4, 2024
Druue
added a commit
to prisma/language-tools
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-06-14.at.20.27.12.mov
Screen.Recording.2024-06-15.at.03.48.47.mov
related: https://github.com/prisma/team-orm/issues/1202
closes: prisma/language-tools#1172