Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockset migration - move upload for queue_times_historical from rockset to s3 #5398

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 3, 2024

Use the machine type and time as the key

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:47pm

@clee2000 clee2000 marked this pull request as ready for review July 3, 2024 23:56
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2024
@clee2000 clee2000 requested a review from a team July 3, 2024 23:56
@@ -48,6 +48,7 @@ SELECT
COUNT(*) AS count,
MAX(queue_s) AS avg_queue_s,
machine_type,
CURRENT_TIMESTAMP() AS _event_time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment on why we need to use CURRENT_TIMESTAMP as _event_time here. I guess that this is because Rockset uses the time when it ingests the data as _event_time. So, re-importing records from S3 will set them all to the same _event_time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes _event_time is the time records get added to rockset if it is empty https://docs.rockset.com/documentation/docs/special-fields#the-_event_time-field

I decided to make a different field entirely so theres less confusion between the two

@clee2000 clee2000 merged commit de45e26 into main Jul 9, 2024
7 checks passed
clee2000 added a commit that referenced this pull request Jul 9, 2024
…ield instead of _event_time and fix env variables in update queue times workflow (#5412)

Related to #5398

Change historical queue times query for HUD metrics page

Looks good
<img width="847" alt="image"
src="https://github.com/pytorch/test-infra/assets/44682903/3376331c-01f6-45e9-a22c-da359ce6df89">

Also change the workflow so we can use workflow dispatch and so that it
has the env vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants