Do not use CDI beans to read the SM #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
fix-491
branch
from
ff9a141
to
aaee351
Compare
loicmathieu
force-pushed
the
fix-491
branch
from
aaee351
to
a012db8
Compare
|
Sure. Sorry for the noise. |
|
Not a problem, this one is a complex beast as it may be used in very early stage of the application and as I'm lazy and don't want to configure a specific CI with access to Google Cloud I find it easier to disable it on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@radcortez now that the secret manager client is loaded earlier, I had to allow disabling it for passing the tests.
I created a branch with your changes and mine, thanks a lot for fixing the issue.
Fixes #491