Don't verify redhat-appstudio/dance-bootstrap-app #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this is a good solution, (or if this bug would actually be a real problem in production), but I'm proposing this change as a quick workaround RHTAPBUGS-1284 for to help get testing unblocked. (This is an alternate version of redhat-appstudio#4 with the new test being done outside of the target branch if block.) Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
|
This was referenced Aug 8, 2024
|
I think this is preferable to #4, wdyt? |
jduimovich
approved these changes
Aug 8, 2024
simonbaird
added a commit
to simonbaird/tssc-sample-pipelines
that referenced
this pull request
Aug 8, 2024
Since the Jenkins version of this is merged now, see [1], let's merge this one also to be consistent. (There should also be an upstream PR in the build-definitions repo at some point.) [1] redhat-appstudio/tssc-sample-jenkins#5 Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
|
Now this is merged, we might want to also merge redhat-appstudio/tssc-sample-pipelines#54 . |
simonbaird
added a commit
to simonbaird/build-definitions
that referenced
this pull request
Aug 8, 2024
This is the upstream change related to the following downstream changes to make sure everything stays in sync. - redhat-appstudio/tssc-sample-jenkins#5 - https://github.com/redhat-appstudio/tssc-sample-pipelines/pull/54/files Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app will never pass an EC check, so try to validate it. This was causing problems during QE testing of the Jenkins pipeline in RHTAP 1.2. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
simonbaird
added a commit
to simonbaird/build-definitions
that referenced
this pull request
Aug 8, 2024
This is the upstream change related to the following downstream changes to make sure everything stays in sync. - redhat-appstudio/tssc-sample-jenkins#5 - redhat-appstudio/tssc-sample-pipelines#54 Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app will never pass an EC check, so try to validate it. This was causing problems during QE testing of the Jenkins pipeline in RHTAP 1.2. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
simonbaird
added a commit
to simonbaird/build-definitions
that referenced
this pull request
Aug 8, 2024
This is the upstream change related to the following downstream changes to make sure everything stays in sync. - redhat-appstudio/tssc-sample-jenkins#5 - redhat-appstudio/tssc-sample-pipelines#54 Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app will never pass an EC check, so try to validate it. This was causing problems during QE testing of the Jenkins pipeline in RHTAP 1.2. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
simonbaird
added a commit
to simonbaird/tssc-sample-pipelines
that referenced
this pull request
Aug 8, 2024
Since the Jenkins version of this is merged now, see [1], let's merge this one also to be consistent. (There should also be an upstream PR in the build-definitions repo at some point.) [1] redhat-appstudio/tssc-sample-jenkins#5 Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good solution, (or if this bug would actually be a real problem in production), but I'm proposing this change as a quick workaround RHTAPBUGS-1284 for to help get testing unblocked.
(This is an alternate version of #4 with the new test being done outside of the target branch if block.)
Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284