-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't verify redhat-appstudio/dance-bootstrap-app #54
Don't verify redhat-appstudio/dance-bootstrap-app #54
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simonbaird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the upstream change related to the following downstream changes to make sure everything stays in sync. - redhat-appstudio/tssc-sample-jenkins#5 - redhat-appstudio/tssc-sample-pipelines#54 Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app will never pass an EC check, so try to validate it. This was causing problems during QE testing of the Jenkins pipeline in RHTAP 1.2. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
This is the upstream change related to the following downstream changes to make sure everything stays in sync. - redhat-appstudio/tssc-sample-jenkins#5 - redhat-appstudio/tssc-sample-pipelines#54 Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app will never pass an EC check, so try to validate it. This was causing problems during QE testing of the Jenkins pipeline in RHTAP 1.2. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
Since the Jenkins version of this is merged now, see [1], let's merge this one also to be consistent. (There should also be an upstream PR in the build-definitions repo at some point.) [1] redhat-appstudio/tssc-sample-jenkins#5 Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
401dd66
to
eb41783
Compare
Removed quotes because checkton didn't like them in build-definitions repo. |
@simonbaird: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
See comments in konflux-ci/build-definitions#1271 this will likely be abandoned. |
Since the Jenkins version of this is merged now, see here, let's merge this one also to be consistent.
(There is an upstream version of this at konflux-ci/build-definitions#1271)
Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284