Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't verify redhat-appstudio/dance-bootstrap-app #54

Conversation

simonbaird
Copy link
Contributor

@simonbaird simonbaird commented Aug 8, 2024

Since the Jenkins version of this is merged now, see here, let's merge this one also to be consistent.

(There is an upstream version of this at konflux-ci/build-definitions#1271)

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284

Copy link

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonbaird
Once this PR has been reviewed and has the lgtm label, please assign jduimovich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

simonbaird added a commit to simonbaird/build-definitions that referenced this pull request Aug 8, 2024
This is the upstream change related to the following downstream changes to
make sure everything stays in sync.

- redhat-appstudio/tssc-sample-jenkins#5
- redhat-appstudio/tssc-sample-pipelines#54

Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app
will never pass an EC check, so try to validate it.

This was causing problems during QE testing of the Jenkins pipeline in RHTAP
1.2.

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
simonbaird added a commit to simonbaird/build-definitions that referenced this pull request Aug 8, 2024
This is the upstream change related to the following downstream changes to
make sure everything stays in sync.

- redhat-appstudio/tssc-sample-jenkins#5
- redhat-appstudio/tssc-sample-pipelines#54

Explanation: For various reasons quay.io/redhat-appstudio/dance-bootstrap-app
will never pass an EC check, so try to validate it.

This was causing problems during QE testing of the Jenkins pipeline in RHTAP
1.2.

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
Since the Jenkins version of this is merged now, see [1], let's
merge this one also to be consistent.

(There should also be an upstream PR in the build-definitions repo
at some point.)

[1] redhat-appstudio/tssc-sample-jenkins#5

Ref: https://issues.redhat.com/browse/RHTAPBUGS-1284
@simonbaird
Copy link
Contributor Author

Removed quotes because checkton didn't like them in build-definitions repo.

Copy link

openshift-ci bot commented Aug 8, 2024

@simonbaird: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhtap-sample-pipelines-yamllint eb41783 link false /test rhtap-sample-pipelines-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonbaird
Copy link
Contributor Author

See comments in konflux-ci/build-definitions#1271 this will likely be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant