-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let sphinx add parameter description with nested structures to documentation #652
Let sphinx add parameter description with nested structures to documentation #652
Conversation
9a3306c
to
0d7bd68
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 47.71% 47.81% +0.10%
==========================================
Files 41 41
Lines 3871 3871
Branches 1833 1827 -6
==========================================
+ Hits 1847 1851 +4
Misses 751 751
+ Partials 1273 1269 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
c6b06f5
to
e4fae73
Compare
42785e3
to
fda15e6
Compare
fda15e6
to
7aa7b3c
Compare
This pull request is in conflict. Could you fix it @christophfroehlich? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that all links point to the correct files and briefly went over the texts. I left a couple of comments on the way that in my opinion improve readability, but since I'm not a native speaker I wouldn't consider them required, hence approving.
description: "Parameter to support broadcasting of only specific joints and interfaces. | ||
It has to be used in combination with the ``joints`` parameter." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest (maybe out of scope), I think having an example on what "has to be used in combination with" would be beneficial. Especially in terms of different scenarios to using map_interface_to_joint_state
.
Also, explaining what leaving the lists empty means would be beneficial in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a text suggestion: feel free to add one. In the meantime, I opened an issue from that ;)
Co-authored-by: Felix Exner (fexner) <[email protected]>
Thanks for the proof reading. I basically merged the infos from the documentation files with them of the yaml -> adding new information is actually out of scope -> I opened an issue for that. @bmagyar can we merge and release that with the same sync than 3.7.0 of generate_parameter_library? I guess we should wait for the next one? |
[JTC docs] Clarify what "joints and interfaces have to be used in com…
This pull request is in conflict. Could you fix it @christophfroehlich? |
This adds automatic documentation generation from generate_parameter_library yamls, where nested structures or
__map_
parameters are used and completes #651Binary builds will fail until generate_parameter_library is released: the multiline description generates invalid C++ code.