-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Improve update methods for tests #858
Merged
bmagyar
merged 15 commits into
ros-controls:master
from
christophfroehlich:jtc/trajectory_error_tests
Nov 27, 2023
Merged
[JTC] Improve update methods for tests #858
bmagyar
merged 15 commits into
ros-controls:master
from
christophfroehlich:jtc/trajectory_error_tests
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
destogl,
malapatiravi,
mhubii,
rosterloh and
sachinkum0009
November 26, 2023 18:05
bmagyar
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 45.51% 45.59% +0.08%
==========================================
Files 40 40
Lines 3636 3636
Branches 1716 1716
==========================================
+ Hits 1655 1658 +3
+ Misses 808 806 -2
+ Partials 1173 1172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
(cherry picked from commit b853228) # Conflicts: # joint_trajectory_controller/test/test_trajectory_controller.cpp # joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 27, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 29, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 29, 2023
bmagyar
pushed a commit
that referenced
this pull request
Nov 30, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 30, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an attempt to improve the JTC tests once more.
The ideas come from #697 and #802, and partially fix them.
state_topic_consistency
is now the only test subscribing to the state message publisher.updateControllerAsync
test method, which calls theupdate()
of JTC with feasible time/period arguments but asynchronous to the current clock.updateController
test method has asleep_for
now, avoiding calling theupdate()
of JTC in the while loop with almost zero duration.<= end_time
instead of< end_time
). This allows for reducing the thresholds, because the points should be reached exactly, independent of any timing issue.joints
thancommand_joints
#809 allowing to reactivate the jump-tests.Overall: The total test time of JTC is decreased by more than 1min. And I hope they are less flaky now.