Deprecate c headers #25
Conversation
Signed-off-by: CursedRock17 <[email protected]>
| @@ -32,7 +32,7 @@ | |||
| #ifndef TF2_SENSOR_MSGS_H | |||
| #define TF2_SENSOR_MSGS_H | |||
|
|
|||
| #include <tf2/convert.h> | |||
| #include <tf2/convert.hpp> | |||
There was a problem hiding this comment.
we should really wrap this with an if/else so that the branch continues to compile on older systems (since I expect this change to tf2 will only be released into rolling and later at this point):
#if __has_include(<tf2/convert.hpp>)
#include <tf2/convert.hpp>
#else
#include <tf2/convert.h>
#endif There was a problem hiding this comment.
This PR was meant to be preemptive one, that being said I'll probably do some backwards compatibility in which earlier branches like Humble will have the .h files include the .hpp files without a warning to prevent this from happening. In that case syntax like this shouldn't be needed.
| @@ -9,7 +9,7 @@ | |||
| #include "gtest/gtest.h" | |||
|
|
|||
|
|
|||
| #include <tf2/LinearMath/Quaternion.h> | |||
| #include <tf2/LinearMath/Quaternion.hpp> | |||
There was a problem hiding this comment.
same as above - let the branch work on multiple distros
|
With the recent backports merged, this PR should be good for review. |
|
This branch supports Humble, Jazzy and Rolling - current status of tf2 headers:
|
|
humble release ros/rosdistro#44053 |
|
@mikeferguson I thought I had permissions here but I don't, we just need to make the release, I already did the tag bloom-release --rosdistro rolling --track rolling imu_pipeline |
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.