Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate c headers #25

Open
wants to merge 2 commits into
base: ros2
Choose a base branch
from
Open

Deprecate c headers #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96bad65
Deprecate tf2 C Headers
CursedRock17 Oct 29, 2024
c665859
Fixing Whitespace
CursedRock17 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion imu_transformer/include/imu_transformer/tf2_sensor_msgs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#ifndef TF2_SENSOR_MSGS_H
#define TF2_SENSOR_MSGS_H

#include <tf2/convert.h>
#include <tf2/convert.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should really wrap this with an if/else so that the branch continues to compile on older systems (since I expect this change to tf2 will only be released into rolling and later at this point):

#if __has_include(<tf2/convert.hpp>)
#include <tf2/convert.hpp>
#else
#include <tf2/convert.h>
#endif

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was meant to be preemptive one, that being said I'll probably do some backwards compatibility in which earlier branches like Humble will have the .h files include the .hpp files without a warning to prevent this from happening. In that case syntax like this shouldn't be needed.

#include <sensor_msgs/msg/imu.hpp>
#include <sensor_msgs/msg/magnetic_field.hpp>
#include <Eigen/Eigen>
Expand Down
2 changes: 1 addition & 1 deletion imu_transformer/test/test_imu_transforms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "gtest/gtest.h"


#include <tf2/LinearMath/Quaternion.h>
#include <tf2/LinearMath/Quaternion.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above - let the branch work on multiple distros

#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp>

#include <Eigen/Eigen>
Expand Down