Port hd_monitor to ROS2 #334 #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to https://github.com/limaanto Squashed commit of the following: commit d21cd6d736a1050b185c070af01f10503a24f4df Merge: 861f924 e67a69c Author: Christian Henkel <[email protected]> Date: Thu Jun 27 10:06:10 2024 +0200 Merge branch 'ros2' into port-hd-monitor Signed-off-by: Christian Henkel <[email protected]> commit 861f924 Author: Antoine Lima <[email protected]> Date: Mon Jun 3 18:13:56 2024 +0200 Fix hd_monitor test commit b9ecd1e Author: Antoine Lima <[email protected]> Date: Wed May 29 01:30:40 2024 +0200 Pass black formatter on hd_monitor and associated test commit a7e68ac Author: Antoine Lima <[email protected]> Date: Wed May 29 01:28:40 2024 +0200 Improve hd_monitor code quality Remove useless print, parameter and format strings according to review of #334 commit 8eba67b Author: Antoine Lima <[email protected]> Date: Wed May 29 01:26:55 2024 +0200 Implement low and crit parameters in hd_monitor commit 6c60eda Author: Antoine Lima <[email protected]> Date: Thu Mar 28 12:13:28 2024 +0100 Add launch test for hd_monitor commit b29cacf Author: Antoine Lima <[email protected]> Date: Thu Mar 28 12:13:10 2024 +0100 Fix execution flag of hd_monitor commit 4cc315d Author: Antoine Lima <[email protected]> Date: Fri Mar 15 17:46:08 2024 +0100 Adapt documentation and CMakeList to new hd_monitor.py commit 2a4eece Author: Antoine Lima <[email protected]> Date: Fri Mar 15 17:34:13 2024 +0100 Port hd_monitor.py Signed-off-by: Christian Henkel <[email protected]>
|
closes #334 |
|
sorry, missed this one 😬 |
|
Okay, there are linter problems. Please rebase #334 and fix them there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to https://github.com/limaanto
Squashed commit of the following:
commit d21cd6d736a1050b185c070af01f10503a24f4df
Merge: 861f924 e67a69c
Author: Christian Henkel [email protected]
Date: Thu Jun 27 10:06:10 2024 +0200
commit 861f924
Author: Antoine Lima [email protected]
Date: Mon Jun 3 18:13:56 2024 +0200
commit b9ecd1e
Author: Antoine Lima [email protected]
Date: Wed May 29 01:30:40 2024 +0200
commit a7e68ac
Author: Antoine Lima [email protected]
Date: Wed May 29 01:28:40 2024 +0200
commit 8eba67b
Author: Antoine Lima [email protected]
Date: Wed May 29 01:26:55 2024 +0200
commit 6c60eda
Author: Antoine Lima [email protected]
Date: Thu Mar 28 12:13:28 2024 +0100
commit b29cacf
Author: Antoine Lima [email protected]
Date: Thu Mar 28 12:13:10 2024 +0100
commit 4cc315d
Author: Antoine Lima [email protected]
Date: Fri Mar 15 17:46:08 2024 +0100
commit 2a4eece
Author: Antoine Lima [email protected]
Date: Fri Mar 15 17:34:13 2024 +0100