-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro #43919
base: master
Are you sure you want to change the base?
Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro #43919
Conversation
…for Humble Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xml
file must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-help
channel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help
channel on our Discord server.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
dynamixel_hardware_interface: | ||
doc: | ||
type: git | ||
url: https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In previous versions of ROS 2, this was released from the OUXT-Polaris repository by @hakuturu583 . What's the relationship between this repository and that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't realize there was a package with the same name.
@hakuturu583, is this package going to be continuously developed in the future?
If so, we will rename it to something else, please confirm it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hakuturu583, We'll rename the package, and we sincerely apologize for the confusion.
@clalancette, We'll come back to this after we've renamed the package and made a revision commit with the relevant changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for notification.
That package is the one we developed when we configured azimuth thrusters for small autonomous vessels with Dynamixel.
https://forum.robotis.com/t/mini-v/1793
We developed and released it because there was no official hardware_interface at that time, but we do not intend to release the package in the future because OUXT Polaris does not need to release it as long as the official release is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hakuturu583
We appreciate your contributions and sincerely apologize for any disappointment in customer support that we may have caused by waiting too long to do what we should have done. We sincerely appreciate your contributions.
So, can we use the name dynamixel_hardware_interface starting with ROS 2 humble?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette As mentioned above, the previous package manager (@hakuturu583) is no longer scheduled for release. So is it okay for our team to use this name (dynamixel_hardware_interface) starting with the humble release?
Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
Please Add This Package to be indexed in the rosdistro.
humble
The source is here:
https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface
https://github.com/ROBOTIS-GIT/dynamixel_interfaces
Checks