Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro #43919

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robotpilot
Copy link
Contributor

Please Add This Package to be indexed in the rosdistro.

humble

The source is here:

https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface
https://github.com/ROBOTIS-GIT/dynamixel_interfaces

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Dec 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

dynamixel_hardware_interface:
doc:
type: git
url: https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous versions of ROS 2, this was released from the OUXT-Polaris repository by @hakuturu583 . What's the relationship between this repository and that one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't realize there was a package with the same name.
@hakuturu583, is this package going to be continuously developed in the future?
If so, we will rename it to something else, please confirm it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakuturu583, We'll rename the package, and we sincerely apologize for the confusion.
@clalancette, We'll come back to this after we've renamed the package and made a revision commit with the relevant changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for notification.
That package is the one we developed when we configured azimuth thrusters for small autonomous vessels with Dynamixel.

https://forum.robotis.com/t/mini-v/1793

We developed and released it because there was no official hardware_interface at that time, but we do not intend to release the package in the future because OUXT Polaris does not need to release it as long as the official release is available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakuturu583
We appreciate your contributions and sincerely apologize for any disappointment in customer support that we may have caused by waiting too long to do what we should have done. We sincerely appreciate your contributions.
So, can we use the name dynamixel_hardware_interface starting with ROS 2 humble?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette As mentioned above, the previous package manager (@hakuturu583) is no longer scheduled for release. So is it okay for our team to use this name (dynamixel_hardware_interface) starting with the humble release?

@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Dec 17, 2024
@robotpilot robotpilot changed the title Add dynamixel_hardware_interface and dynamixel_interface to rosdistro Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro Dec 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@audrow audrow requested a review from clalancette December 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants