Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro #43919

Closed
wants to merge 8 commits into from
Closed

Add dynamixel_hw_interface and dynamixel_interfaces to rosdistro #43919

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c0966b6
Deleted the open_manipulator_with_tb3_msgs on ROS Kinetic
robotpilot Feb 11, 2019
9fe803f
Merge branch 'ros:master' into master
robotpilot Dec 2, 2024
f8075d1
Merge branch 'master' of https://github.com/ros/rosdistro
robotpilot Dec 10, 2024
aec2e9e
Merge branch 'master' of https://github.com/ros/rosdistro
robotpilot Dec 16, 2024
2a1165d
Add dynamixel_hardware_interface and dynamixel_interface source info …
robotpilot Dec 16, 2024
5bcf6f8
Modified the package name
robotpilot Dec 18, 2024
a317b0d
Modified the package name
robotpilot Dec 23, 2024
4b51cfd
Merge branch 'ros:master' into feature-dynamixel-hardware-interface
robotpilot Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions humble/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,6 +1976,26 @@ repositories:
url: https://github.com/dynamixel-community/dynamixel_hardware.git
version: humble
status: developed
dynamixel_hardware_interface:
doc:
type: git
url: https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous versions of ROS 2, this was released from the OUXT-Polaris repository by @hakuturu583 . What's the relationship between this repository and that one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't realize there was a package with the same name.
@hakuturu583, is this package going to be continuously developed in the future?
If so, we will rename it to something else, please confirm it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakuturu583, We'll rename the package, and we sincerely apologize for the confusion.
@clalancette, We'll come back to this after we've renamed the package and made a revision commit with the relevant changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for notification.
That package is the one we developed when we configured azimuth thrusters for small autonomous vessels with Dynamixel.

https://forum.robotis.com/t/mini-v/1793

We developed and released it because there was no official hardware_interface at that time, but we do not intend to release the package in the future because OUXT Polaris does not need to release it as long as the official release is available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakuturu583
We appreciate your contributions and sincerely apologize for any disappointment in customer support that we may have caused by waiting too long to do what we should have done. We sincerely appreciate your contributions.
So, can we use the name dynamixel_hardware_interface starting with ROS 2 humble?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette As mentioned above, the previous package manager (@hakuturu583) is no longer scheduled for release. So is it okay for our team to use this name (dynamixel_hardware_interface) starting with the humble release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette We believe this issue has been resolved and would prefer to keep the package name as originally proposed. Please reconsider.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a lot of people have been on vacation for the past few weeks.

I think this PR should be good, but I'm adding it to the agenda for the ROS PMC meeting tomorrow just to confirm with others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. Thank you very much. :)

version: humble
source:
type: git
url: https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git
version: humble
status: developed
dynamixel_interfaces:
doc:
type: git
url: https://github.com/ROBOTIS-GIT/dynamixel_interfaces.git
version: humble
source:
type: git
url: https://github.com/ROBOTIS-GIT/dynamixel_interfaces.git
version: humble
status: developed
dynamixel_sdk:
doc:
type: git
Expand Down
Loading