-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get valid subscription handle even if cft failed #106
base: rolling
Are you sure you want to change the base?
get valid subscription handle even if cft failed #106
Conversation
Signed-off-by: Chen Lihui <[email protected]>
…d-handle-even-if-cft-failed Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
This reverts commit 7e67759. Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment needs to be confirmed but lgtm.
@asorbini we would like to request the another review on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iuhilnehc-ynos thank you for submitting these changes, and apologies for the late reply.
The change looks good to me, but I'm not sure why they are needed.
Is the ROS filtering syntax different than the standard DDS one?
If not, I would assume a failure to create the CFT signals some problem with the parameters, and it should not be ignored.
If there are filters that are only supported by the rcl implementation, then this change is fine.
Thanks for your reply. No matter when you reply, it's never too late.
No, I think it's the same for now, maybe |
…d-handle-even-if-cft-failed
rcl need to continue to try rcl cft fallback if rmw implementation failed to call rmw cft.