Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ancillary methods and stubs #5

Merged
merged 19 commits into from
Aug 17, 2020
Merged

Implement ancillary methods and stubs #5

merged 19 commits into from
Aug 17, 2020

Conversation

methylDragon
Copy link
Contributor

This PR implements required ancillary methods that are used in the pub-sub flow.

NOTE: This must ONLY be merged AFTER #3

@methylDragon methylDragon mentioned this pull request Aug 7, 2020
Merged
@methylDragon methylDragon added the enhancement New feature or request label Aug 7, 2020
gbiggs
gbiggs requested changes Aug 12, 2020
View reviewed changes
rmw_zenoh_cpp/src/rmw_event.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_event.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_gids.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_gids.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_gids.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_wait_sets.cpp Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_guard_conditions.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_wait_sets.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_wait_sets.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/types/guard_condition.hpp Outdated Show resolved Hide resolved
@methylDragon methylDragon merged commit 0598213 into ros2:main Aug 17, 2020
@methylDragon methylDragon deleted the ch3/ancillary-methods branch August 17, 2020 05:59
clalancette added a commit that referenced this pull request Nov 9, 2023
@clalancette
Fix up leaks in the node and publisher initialization (#5)
abe4298 
* Make sure to cleanup in both context init and fini.

Signed-off-by: Chris Lalancette <[email protected]>

* Fixup style in the GuardCondition class.

Signed-off-by: Chris Lalancette <[email protected]>

* Fix up leaks in rmw_publish family of functions.

Signed-off-by: Chris Lalancette <[email protected]>

---------

Signed-off-by: Chris Lalancette <[email protected]>
Yadunund pushed a commit that referenced this pull request Jan 12, 2024
@clalancette @Yadunund
Fix up leaks in the node and publisher initialization (#5)
6f8262a 
* Make sure to cleanup in both context init and fini.

Signed-off-by: Chris Lalancette <[email protected]>

* Fixup style in the GuardCondition class.

Signed-off-by: Chris Lalancette <[email protected]>

* Fix up leaks in rmw_publish family of functions.

Signed-off-by: Chris Lalancette <[email protected]>

---------

Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @gbiggs