Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev environment for scan control driver testing #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NithishkumarS
Copy link
Contributor

@NithishkumarS NithishkumarS commented Dec 8, 2023

Update the docker image to support building the scancontrol package in the container

Jira issue: LH2-213

Motivation and Context

ROS Noetic is no longer supported on the newer Ubuntu versions. Therefore a docker container is used to build and run the scancontrol package on newer Ubuntu version. To build the package the base image needs to be updated to include the build essentials.

Changes

  • Update the ROS image used and dependencies
  • Update the usage Instructions

Type of changes:

  • New feature

Checklist

  • Update README

@@ -64,12 +64,19 @@ RUN mkdir /library_pkgs && \
mv "/scanCONTROL-Linux-SDK/libmescan/builddir/mescan_${SCANCONTROL_SDK_VERSION}-1_amd64.deb" /library_pkgs && \
mv "/scanCONTROL-Linux-SDK/libllt/builddir/llt_${SCANCONTROL_SDK_VERSION}-1_amd64.deb" /library_pkgs

FROM ros:noetic-ros-core
FROM osrf/ros:noetic-desktop-full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full desktop image is overkill. Please use something like ros:noetic-ros-base as those include the essential build tools already.

@Pugens
Copy link

Pugens commented Jan 29, 2024

Hi @NithishkumarS, could you add some more info on how to use this as an actual dev container? Or is it only for ci testing purposes? Thx!

@Pugens
Copy link

Pugens commented Jan 29, 2024

Hi @NithishkumarS, could you add some more info on how to use this as an actual dev container? Or is it only for ci testing purposes? Thx!

I also tried the official image online here https://hub.docker.com/r/samxl/scancontrol/tags
There is a ros noetic installation, but not build tools!? I cannot complie catkin ws inside the container:
bash: catkin: command not found

@Pugens
Copy link

Pugens commented Jan 30, 2024

If we want to reuse the Dockerfile for actual development envs, rather than just CI, I did an attempt at improvements here @dave992 @NithishkumarS: https://github.com/Pugens/scancontrol/tree/improve-docker-dependencies-built

@katettudelft
Copy link

If we want to reuse the Dockerfile for actual development envs, rather than just CI, I did an attempt at improvements here @dave992 @NithishkumarS: https://github.com/Pugens/scancontrol/tree/improve-docker-dependencies-built

We've now got at least three competing Dockerfile defs for ROS2 dev environments (@Pugens I know that one isn't strictly ROS related). There are a lot of standard optimisations that ought to be applied (both for error avoidance and for size management). I'm going to request some time in the new sprint to try to get things untangled a bit; I'd be happy to hear any opinions from anyone.

@Pugens Pugens mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants