-
Notifications
You must be signed in to change notification settings - Fork 46
New reader for G4X datasets (Singular Genomics) #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…l kwargs, use dask array imread
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 39.16% 46.41% +7.24%
==========================================
Files 26 27 +1
Lines 2663 2995 +332
==========================================
+ Hits 1043 1390 +347
+ Misses 1620 1605 -15
🚀 New features to boost your workflow:
|
Hi @LucaMarconato, I would like to pick up this PR and get it past the pre-commit checks. How do you suggest me continuing? Should I create a fresh clone of the feature on the current main branch? |
Hi @floRaths, thanks for reaching out! You could open a PR against this PR, or if you want merge this PR in a new PR (from you) against main. As you prefer. We recently added a contributed guide for Also, in case you want to discuss via chat or setup a meeting, we offer community meetings every 2 weeks (covering different time zones): #spatial > spatialdata meetings @ 💬. |
👋 Hello @scverse/spatialdata and community,
I would like to contribute the initial version of a
spatialdata-io
reader for Singular Genomics G4X datasets that I recently developed for internal use (I work at Singular), and now for the spatial community. It is still experimental and not fully battle-tested, but I tried to keep the API consistent with the other readers as much as possible. However, there are few key additions I made to streamline use with our datasets:Notable features
g4x(..., mode="append")
parameter. The user can also choosemode="overwrite"
to turn this off. The constructedSpatialData
is also re-read from disk automatically to fully take advantage of lazy loading.SpatialData
object or a list of them accordingly.Additional Dependencies
.jp2
,j2k
) format and require theglympur
package to readMisc.
Are there any other pieces I should have in this PR? Devs please let me know, I'm happy to add them. Here are relevant ones I can think of:
@injectdocs
decorator properly)spatialdata-io
CLI compatibility