Make new palm flesh the default palm for Hands E and G (lite) #844
+22
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make new hand versions (with new palm flesh) the default versions for Hands E and G (lite), respectively, versions E4 and G4.
Also, renaming node
error_reporter
node tounderactuation_error_reporter
for clarity purposes and ensuring parametersrobot_description
androbot_description_semantics
are discoverable before starting the node.Update: This PR also now introduces fixes to some of our ROS tests (specifically, those invoking the method move_group.compute_cartesian_path() ), so that they now conform with the latest API changes to moveit_commander:
moveit/moveit#3618
Specifically, the argument
jump_threshold
has now been deprecated, and, therefore, had to be removedChecklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation