Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced some calls to the Form::radio helper #16176

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

This PR replaces calls to Form::radio with plain html on the bulk users edit and custom report pages.

Bulk Users Edit:
radios on bulk edit users page

Custom Report:
radios on custom report


On the Bulk Users Edit page I adjusted some labels as well since some ids were reused and made selecting "Do Not Change" wouldn't work:
do not change unselectable

Copy link

what-the-diff bot commented Feb 4, 2025

PR Summary

  • Enhanced Input Methods
    The radio button inputs have been modified to use native HTML elements instead of Laravel Form functions. This change has been implemented in custom.blade.php and bulk-edit.blade.php files. This helps increase the readability of the code and it is easier to maintain.
  • Improved Accessibility
    We have improved the website's accessibility by correcting aria-label attributes to match the inputs. This helps people who use screen readers to better understand the content.
  • Checked Assigned Values
    We have directly checked the values assigned to inputs. This increases readability and makes maintenance simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant