Support TWAMP Light notification in syncd #1306
Conversation
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
3 times, most recently
from
ce8f3c2 to
f1e9460
Compare
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
f1e9460 to
9a34d52
Compare
| SWSS_LOG_ERROR("data.twamp_session_id %s has unexpected type: %s, expected TWAMP_SESSION", | ||
| sai_serialize_object_id(data.twamp_session_id).c_str(), | ||
| sai_serialize_object_type(ot).c_str()); | ||
| break; |
There was a problem hiding this comment.
just return here ? and valid variable is not needed
There was a problem hiding this comment.
Thanks for comments.
It should check the object type of session_id whether it is TWAMP session. So we add valid variable and set as true when the object type is TWAMP session, otherwise use default value as false. If the valid variable is false, it would just return the error log.
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
4 times, most recently
from
f16be56 to
1178a2c
Compare
|
please resolve merge conflicts |
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
1178a2c to
78d2ac0
Compare
syncd/Syncd.cpp
Outdated
| @@ -4395,7 +4396,8 @@ void Syncd::performWarmRestartSingleSwitch( | |||
| SAI_SWITCH_ATTR_NAT_EVENT_NOTIFY, | |||
| SAI_SWITCH_ATTR_PORT_STATE_CHANGE_NOTIFY, | |||
| SAI_SWITCH_ATTR_QUEUE_PFC_DEADLOCK_NOTIFY, | |||
| SAI_SWITCH_ATTR_BFD_SESSION_STATE_CHANGE_NOTIFY | |||
| SAI_SWITCH_ATTR_BFD_SESSION_STATE_CHANGE_NOTIFY, | |||
| SAI_SWITCH_ATTR_TWAMP_SESSION_EVENT_NOTIFY | |||
There was a problem hiding this comment.
this entire list could be obtained from sai_metadata_switch_notify_attr, and there will be no need in the future to update that, i will make PR for this after your will merge
There was a problem hiding this comment.
Got it. Whether I would do nothing before you make PR.
There was a problem hiding this comment.
go on proceeded with yours, i will add my on top of it
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
78d2ac0 to
2380cee
Compare
Signed-off-by: yoush <[email protected]>
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
2380cee to
dbf8408
Compare
|
/azpw run |
Signed-off-by: yoush <[email protected]>
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
dbf8408 to
a392676
Compare
Signed-off-by: yoush <[email protected]>
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
a392676 to
fb17397
Compare
Signed-off-by: yoush <[email protected]>
AlanYoush
force-pushed
the
devpr_yoush_support_twamp_light_in_sairedis
branch
from
fb17397 to
f0b80b7
Compare
|
@kcudnik Thank you very much for approving it. I am wondering if you are able to merge it ? If you can, please help to merge it, because PR (sonic-net/sonic-swss#2927) depends on it. |
|
@kcudnik Thanks very much |
For supporting TWAMP Light, it requires vendor-sai to report TWAMP Light mearsurement data from silicon.
And, so it defines the notification event and getting statistics function in SAI and invokes them in syncd.