Unused includes cleanup #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add a CI run which does this check? |
|
clang-tidy has misc-include-cleaner, but this is very recent. Our CI has all misc checks already switched on, but the clang-tidy used is too old. RICB has IWYU functionality, that could be an option. I've tried that once locally, I believe, but could not get it working. Maybe you're able add it to our CI? |
|
Sounds good. Might be easier to try and upgrade clang-tidy at some point. |
Levi-Armstrong
approved these changes
Oct 11, 2023
Levi-Armstrong
merged commit 7e044fc
into
tesseract-robotics:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used clangd to check all files for unused includes