-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fix eigen variable definition #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
hakuturu583
added
wait for regression test
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
and removed
wait for regression test
labels
Sep 17, 2024
hakuturu583
changed the title
Fix/fix eigen variable definition (DO NOT MERGE!!!)
Fix/fix eigen variable definition
Sep 18, 2024
Fixing release action is working on #1248 |
yamacir-kit
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1302, #1312
Abstract
Fix the definition of eigen variable for calculation of ego vehicle pose.
Background
In #1302, it is reported that kinematic state is not updated.
I have discovered a bug where pull requests from forks cannot be merged due to the Release Action malfunctioning.
Since #1313 is very important and needs to be incorporated urgently, @hakuturu583 will create a similar pull request and carry out verification and merging.
This Pull request is not @hakuturu583 's work, it is @MertClk 's work.
Thank you very much for contribution.
References
Reference to fix:
This behavior is presumably due to the fact that the Eigen calculation is delayed by the Expression Template, resulting in undefined values. However, a tier4 internal verification showed that this part should not have been a problem even if auto had been used.
One possibility is that the behavior may be CPU architecture dependent.
The cause is unknown, but since there is no particular disadvantage, this PR is merged.
https://github.com/tier4/sim_evaluation_tools/issues/342
#1313