Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects apigw API #115

Merged
merged 36 commits into from
Apr 29, 2024
Merged

Objects apigw API #115

merged 36 commits into from
Apr 29, 2024

Conversation

brainstorm
Copy link
Member

@brainstorm brainstorm commented Feb 22, 2024 •
edited
Loading

Adds endpoints to query the filemanager model from REST (API Gateway V2). Also:

  • Refactors and promotes api-gw from SRM to top level.
  • Fixes all workloads to use the new construct instead of custom ones per service.
  • Adds AccessLog logGroup.
  • Explores CloudMap at ApiGw level.

@brainstorm
Get rust-analyzer working again
e353d41
@brainstorm
Apigw CDK scaffold for the lambda (objects) query functionality
d4195a4
@brainstorm
Readable version of the (hand-crafted) filemanager OpenAPI from month…
99763c0 
…s ago, probably should be discarded at this point
@brainstorm
Point to the right function, thanks @mmalenic [ci skip]
c73a1da
@brainstorm
Ignore caches and Cargo.lock from skel/rust to avoid dependabot buggi…
2052cfa 
…ng us on it
@brainstorm
Scaffold for Rust-side query objects api [ci skip]
0290e1d
@brainstorm
Try SIMILAR TO, which is closer to regex syntax than LIKE: https://ww…
23afd08 
…w.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-LIKE ... I still don't like to pass user input as-is though, this is just a dev test... [ci skip]
@brainstorm
Merge branch 'main' of https://github.com/umccr/orcabus into objects_…
a6e4d00 
…apigw_api
@brainstorm
Own stack for API gateway testing
5ad221d
@brainstorm
Merge filemanager apigw branch w/ main
207eb98
@brainstorm
Adjust lifetimes for Client on the query module
30a85be
@brainstorm
Simplify docs, remove unused warning
47da4d2
@brainstorm
Github conflicting files do not seem to be conflicting locally..
4df267e
@brainstorm
Fix conflicts
47c7ccb
@brainstorm
Keeping up with the stack tree reorg
25a39c4
@brainstorm
compose's version field obsolete, interesting and welcome deprecation…
04cfe88 
…: '(...) filemanager/compose.yml: is obsolete'
@brainstorm
Fix ApiGateway v2 CDK for Filemanager Query lambda
0fafe33
@brainstorm brainstorm marked this pull request as ready for review April 19, 2024 04:28
@brainstorm brainstorm added the filemanager an issue relating to the filemanager label Apr 22, 2024
@brainstorm
Make TODO stand out, more ripgrep-friendly
b4a18da
@brainstorm
Pass correct package (filemanager-api) to stack to match query functi…
19f8011 
…on Cargo.toml name, first successful stub deploy. Need to refactor/eliminate lib/filemanager.ts in favor of stack.ts, too many sites to edit when adding a new function, thus error-prone /cc @mmalenic
@brainstorm
Remove old stack
343bd1f
@brainstorm
Fix id naming glitch with stack name, add access logs, explore CloudM…
2c7a91d 
…ap based on https://github.com/aws-samples/aws-cdk-service-discovery-example
@brainstorm
Substitute custom policy/role for a managed one: https://docs.aws.ama…
11f972d 
…zon.com/aws-managed-policy/latest/reference/AmazonAPIGatewayPushToCloudWatchLogs.html
@brainstorm
Bizarre TS import rules... was getting 'Cannot read properties of und…
6088bf5 
…efined (reading 'Role')'...
@brainstorm
Respect OrcaBusAPI prefix as observed in other u-services
01a1c4d
@brainstorm brainstorm self-assigned this Apr 26, 2024
@victorskl
Copy link
Member

will review today

@victorskl victorskl mentioned this pull request Apr 28, 2024
Merged
@victorskl
Copy link
Member

reviewing...

victorskl
victorskl approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment/suggestion to attend.

lib/workload/components/api-gateway/index.ts Show resolved Hide resolved
lib/workload/components/api-gateway/index.ts Outdated Show resolved Hide resolved
lib/workload/stateless/stacks/filemanager/deploy/stack.ts Show resolved Hide resolved
lib/workload/stateless/stacks/metadata-manager/deploy/stack.ts Show resolved Hide resolved
lib/workload/stateless/stacks/sequence-run-manager/deploy/stack.ts Outdated Show resolved Hide resolved
@brainstorm brainstorm merged commit 40c7e9a into main Apr 29, 2024
2 checks passed
@brainstorm brainstorm deleted the objects_apigw_api branch April 29, 2024 04:06
@victorskl victorskl linked an issue Apr 29, 2024 that may be closed by this pull request
filemanager: add API gateway infrastructure for filemanager. #109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpatto andrewpatto andrewpatto left review comments

@victorskl victorskl victorskl approved these changes

@mmalenic mmalenic Awaiting requested review from mmalenic

Assignees

@brainstorm brainstorm

Labels
filemanager an issue relating to the filemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: add API gateway infrastructure for filemanager.
3 participants
@brainstorm @victorskl @andrewpatto