fix(filemanager): use docker run to get unique containers #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
force-pushed
the
fix/docker-container-name
branch
2 times, most recently
from
510480a to
bba9d0b
Compare
mmalenic
force-pushed
the
fix/docker-container-name
branch
from
bba9d0b to
262e7c4
Compare
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #180 and #183.
Not sure exactly why the CodeBuild docker error occurs, but I think it's something to do with running
docker composein parallel. E.g. try runningdocker compose up & docker compose upand the same error occurs.Either way, to hopefully fix this for good, the changes are:
docker compose runin the CDK code, which always creates a unique container name with a random suffix.docker compose up.0.0.0.0:0to create an arbitrary host:port mapping to the host.Makefileand.env.exampleto reflect these changes.