Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filemanager): use docker run to get unique containers #184

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Mar 25, 2024

Related to #180 and #183.

Not sure exactly why the CodeBuild docker error occurs, but I think it's something to do with running docker compose in parallel. E.g. try running docker compose up & docker compose up and the same error occurs.

Either way, to hopefully fix this for good, the changes are:

  • Use docker compose run in the CDK code, which always creates a unique container name with a random suffix.
    • Local dev can still use docker compose up.
  • Use address and port 0.0.0.0:0 to create an arbitrary host:port mapping to the host.
  • Rearrange Makefile and .env.example to reflect these changes.

@mmalenic mmalenic self-assigned this Mar 25, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager fix labels Mar 25, 2024
@mmalenic mmalenic force-pushed the fix/docker-container-name branch 2 times, most recently from 510480a to bba9d0b Compare March 25, 2024 02:39
@mmalenic mmalenic force-pushed the fix/docker-container-name branch from bba9d0b to 262e7c4 Compare March 25, 2024 02:40
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorskl victorskl linked an issue Mar 25, 2024 that may be closed by this pull request
@mmalenic mmalenic merged commit 8b2301c into main Mar 25, 2024
2 checks passed
@mmalenic mmalenic deleted the fix/docker-container-name branch March 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: reconfigure deployment to match other microservices
2 participants