Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/c1t sllidar driver #318

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

afrye51
Copy link
Contributor

@afrye51 afrye51 commented Feb 16, 2024

PR Details

Description

Adding c1t carma-config, with ssc and lidar drivers. DSRC is still to be pulled in.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afrye51 afrye51 self-assigned this Feb 16, 2024
Copy link

@willjohnsonk willjohnsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment- if we split this up across two PCs I assume we may need either two carma-configs or a carma-config that specifies which system the nodes will be running on similar to how it was done for dual compute

ros__parameters:
subsystem_namespace: /hardware_interface
required_subsystem_nodes: ['']
unmanaged_required_nodes: ['']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that in other configs the driver wrappers in localization get put into excluded, does this also apply here?

sensor_nodes:
- /hardware_interface/sllidar_ros2_driver_wrapper
- /hardware_interface/bno055_ros2_driver_wrapper
sensor_fault_map: '

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any info on what this is and if it applies going from a 3d lidar config to a 2d one?

# Acceleration limit
# Value type: Desired
# Units: m/s^2
vehicle_acceleration_limit: 2.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the accel limits and jerk limits could probably be reduced from full-scale. Couldn't say a good value but maybe in the <1m/s2 range?

- /environment/detection/object_tracker/objects_markers
- /environment/detection/objects

exclude_can: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that the CAN interface should always be excluded on C1T

- /environment/detection/object_tracker/objects_markers
- /environment/detection/objects

exclude_camera: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be true since there's no camera?

//Private variables
var ip = '192.168.0.100';
var refresh_interval = 30; //30 seconds
var ros_connect_wait = 5000; //5 miliseconds to wait for platform to launch and ros to connect.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is deployed to a split PC system this value may need to be increased to account for latency

<arg name="cuda" value="true"/>

<!-- Set the Frame of the Lidar(s) -->
<arg name="combined_lidar_frame" value="velodyne"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this value be slamtec?

<arg name="launch_drivers" default="false"/>

<!-- Rosbag Flag -->
<arg name="use_rosbag" default="true"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we have changed some things with rosbags in ROS2 and this seems to have been removed from the other carma configs, may be unnecessary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't include the vector map declaration, I assume we will need this

network_mode: host
container_name: web-ui
environment:
- ROS_IP=192.168.88.10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to match the rest of the ROS_IPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants