Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cdar 746 remove debug scenario runner #320

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Cdar 746 remove debug scenario runner #320

merged 1 commit into from
Feb 16, 2024

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Feb 16, 2024 •
edited

PR Details

Description

Debug flag causes following error in scenario runner (carla-simulator/scenario_runner#1055)

Related Issue

carla-simulator/scenario_runner#1055

Motivation and Context

Avoid scenario runner crashes

How Has This Been Tested?

CDASim deployment

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review February 16, 2024 22:07
@paulbourelly999 paulbourelly999 marked this pull request as draft February 16, 2024 22:07
@paulbourelly999 paulbourelly999 changed the base branch from develop to release/lavida February 16, 2024 22:07
@paulbourelly999 paulbourelly999 marked this pull request as ready for review February 16, 2024 22:07
@MishkaMN MishkaMN merged commit 97e133d into release/lavida Feb 16, 2024
@MishkaMN MishkaMN deleted the cdar-746-remove-debug-scenario-runner branch February 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishkaMN MishkaMN MishkaMN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulbourelly999 @MishkaMN