-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add launch for oak #113
base: master
Are you sure you want to change the base?
add launch for oak #113
Conversation
workspace/src/common/launch/art_oak_launch/launch/art_oak.launch.py
Outdated
Show resolved
Hide resolved
workspace/src/common/launch/art_oak_launch/launch/art_oak.launch.py
Outdated
Show resolved
Hide resolved
Gonna hold off on reviewing till we discuss in #116 |
oops |
dollar |
is there a way for me to change the name of this branch while leaving the PR open? |
ya just push to the new branch name and then update this PR with that branch |
# ------------- | ||
# Composability | ||
# ------------- | ||
|
||
AddLaunchArgument(ld, "container", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only comment is adding spaces above and below this haha
Doesn't actually do anything different than
art_dev_meta
atm (and I doubt this actually works bcs some stuff was removed). Just adding the framework for oak to be able to launch before adding in specific nodes.