modify launch docs #116
modify launch docs #116
Conversation
StefanCaldararu
added
the
documentation
|
|
||
| ## `art_dev_launch/` | ||
|
|
||
| The purpose of this file is to define system wide parameters (e.g. `LaunchConfigurations`, `LaunchDescriptions`, etc.) for the `dev` service. This will allow all orchestrators to know which specific packages to launch, and which to ignore. This is currently set up to run a cone-based path following demo, but can be used to test any other packages. |
There was a problem hiding this comment.
is this true? are those system wide parameters included by the vehicle specific launches or are they copied?
There was a problem hiding this comment.
I'm not sure what you mean here; if the vehicle has the exact same intended task, then yes the params are just copied. If a certain package is intended to be launched in the exact same way, then yes it is just copied (e.g. both services want "EKF"). But in my mind two vehicles / services don't necessarily share any parameters, so they should each define them themselves.
There was a problem hiding this comment.
maybe some of the "use_sim parameters would make sense to be shared, but even those I could see some scenarios where they shouldn't be...
|
@AaronYoung5 pinging for another review |
#112 , but they were actually fine, so mostly just made modifications relating to #113 . Will probably need to be modified if #113 changes. @AaronYoung5 idk how you do it but the docs are actually fire. I think they're just dense so take some time to digest....