Remove extra -headerpad linker argument

According to the Clang 15 man page it needs a size argument, and I don't think it does anything we need that `-headerpad_max_install_names` doesn't do. And it is causing build failures for some people (see <https://www.biostars.org/p/9598655/>) because it doesn't have an argument.
vgteam · Jul 15, 2024 · 462dc6b · 462dc6b · adamnovak · Jul 15, 2024
1 parent d3f9dec
commit 462dc6b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -216,8 +216,9 @@ ifeq ($(shell uname -s),Darwin)
     START_STATIC =
     END_STATIC =
 
-    # We need to use special flags to let us rename libraries
-    LD_RENAMEABLE_FLAGS = -Wl,-headerpad -Wl,-headerpad_max_install_names
+    # We need to use special flags to let us rename libraries.
+    # See <https://github.com/Homebrew/legacy-homebrew/issues/20233>
+    LD_RENAMEABLE_FLAGS = -Wl,-headerpad_max_install_names
 else
     # We are not running on OS X
     $(info OS is Linux)