Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning to giraffe when using minimizers without distance hints #3985

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xchang1
Copy link
Contributor

@xchang1 xchang1 commented Jun 10, 2023

Changelog Entry

To be copied to the draft changelog by merger:

  • Add a warning to giraffe when using minimizers without distance hints

Description

Running giraffe with minimizers that don't include the distance hints in the payload is very slow. Warn users when this happens

@xchang1
Copy link
Contributor Author

xchang1 commented Jun 11, 2023

Actually this is too slow and it would be too difficult to try to go through just a handful of minimizers or reads before mapping. I think it would be better to try to change the minimizer index to remember if it has distances or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants