Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust path parsing #4010

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Robust path parsing #4010

merged 2 commits into from
Jul 3, 2023

Conversation

adamnovak
Copy link
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • Paths that look like PanSN but aren't, due to having a non-numeric haplotype number field, will no longer be parsed, and should thus no longer produce crashes due to parsing failures.

Description

This should fix #3712.

It probably still needs a unit test to actually reproduce the problem.

@adamnovak adamnovak mentioned this pull request Jul 3, 2023
Closed
@adamnovak
Copy link
Member Author

I tested this manually and it seems to work.

@adamnovak adamnovak merged commit be7fa18 into master Jul 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in 'vg autoindex' a GFA file derived from PGGB
1 participant
@adamnovak