Unify libhandlegraphs #4115
Merged
Unify libhandlegraphs #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
This uses vgteam/libvgio#66 and vgteam/libhandlegraph#95 to make sure that libvgio builds against our installed-into-the-build-tree libhandlegraph, instead of its bundled one.
This should finally banish the weird vtable problems caused when the libhandlegraph versions get out of sync across the repos.
(libbdsg and xg also still ship libhandlegraph submodules, but we don't use their CMake build systems to build them in vg, so we don't build those submodules.)